Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(glyphs): adjust formatting and add loader #334

Merged
merged 3 commits into from
Dec 2, 2021
Merged

fix(glyphs): adjust formatting and add loader #334

merged 3 commits into from
Dec 2, 2021

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Dec 2, 2021

What this PR does πŸ“–
Change glyph formatting, add collapse functionality, and fix a number of display related bugs.

Which issue(s) this PR fixes πŸ”¨

Fixes #AP-100, #AP-120

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

changes glyph size, fixes scroll error, adds loaders. also fixes glyph selection window bug
closes #100,#120
collapse functionality for glpyh groups, also fixes hover bug with banner
@josephmcg josephmcg changed the title Ap 100 fix(glyphs): adjust formatting and add loader Dec 2, 2021
Copy link
Contributor

@WanderingHogan WanderingHogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks & works great

@WanderingHogan WanderingHogan added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Dec 2, 2021
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty neat! πŸŽ‰

@stavares843 stavares843 merged commit a66ca9e into dev Dec 2, 2021
@stavares843 stavares843 deleted the AP-100 branch December 2, 2021 04:03
@github-actions github-actions bot removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants